Re: [PATCH] watchdog: wdat_wdt: Select WATCHDOG_CORE

[Guenter Roeck]

On 11/21/2016 05:33 AM, Mika Westerberg wrote:
> The WDAT watchdog driver uses functionality provided by the watchdog timer
> core but it did not select it explicitly. This results following linker
> error when only WDAT_WDT is enabled in Kconfig:
>
>   drivers/built-in.o: In function `wdat_wdt_probe':
>   drivers/watchdog/wdat_wdt.c:444: undefined reference to `devm_watchdog_register_device'
>
> Fix this by explicitly selecting WATCHDOG_CORE when WDAT watchdog driver is
> enabled.
>
> Fixes: 058dfc767008 (ACPI / watchdog: Add support for WDAT hardware watchdog)
> Reported-by: Vegard Nossum <vegard.nossum@xxxxxxxxx>
> Signed-off-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>

Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>

> ---
>  drivers/watchdog/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
> index fdd3228e0678..3eb58cb51e56 100644
> --- a/drivers/watchdog/Kconfig
> +++ b/drivers/watchdog/Kconfig
> @@ -155,6 +155,7 @@ config TANGOX_WATCHDOG
>  config WDAT_WDT
>  	tristate "ACPI Watchdog Action Table (WDAT)"
>  	depends on ACPI
> +	select WATCHDOG_CORE
>  	select ACPI_WATCHDOG
>  	help
>  	  This driver adds support for systems with ACPI Watchdog Action