Re: [PATCH 1/2] clk: qcom: clk-smd-rpm: Fix clk_hw_onecell_data references

From: Stephen Boyd
Date: Mon Nov 21 2016 - 18:13:19 EST


On 11/21, Georgi Djakov wrote:
> The clk_hw_onecell_data struct is missing references to the
> actual clocks. Fix this.
>
> Reported-by: Michael Scott <michael.scott@xxxxxxxxxx>
> Signed-off-by: Georgi Djakov <georgi.djakov@xxxxxxxxxx>
> ---
> drivers/clk/qcom/clk-smd-rpm.c | 20 +++++++++-----------
> 1 file changed, 9 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/clk/qcom/clk-smd-rpm.c b/drivers/clk/qcom/clk-smd-rpm.c
> index a27013dbc0aa..58821f7213b0 100644
> --- a/drivers/clk/qcom/clk-smd-rpm.c
> +++ b/drivers/clk/qcom/clk-smd-rpm.c
> @@ -148,8 +148,7 @@ struct clk_smd_rpm_req {
>
> struct rpm_cc {
> struct qcom_rpm *rpm;
> - struct clk_hw_onecell_data data;
> - struct clk_hw *hws[];
> + struct clk_hw_onecell_data *data;

How about rolling our own xlate function to return hw pointers?
We already have a list of hws here, so it doesn't seem like much
more to do.

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project