Re: [PATCH 2/3] thermal: rockchip: improve conversion error messages

[Caesar Wang]

å 2016å11æ19æ 11:31, Caesar Wang åé:
> Brian,
>
> å 2016å11æ19æ 07:52, Brian Norris åé:
> > These error messages don't give much information about what went wrong.
> > It would be nice, for one, to see what invalid temperature was being
> > requested when conversion fails. It's also good to return an error when
> > we can't handle a conversion properly.
> >
> > While we're at it, fix the grammar too.
> >
> > Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> > ---
> > Note: it'd probably be even nicer to know which sensor this was, but 
> > we've
> > kinda abstracted that one away by this point...
> >
> >   drivers/thermal/rockchip_thermal.c | 7 +++++--
> >   1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/thermal/rockchip_thermal.c 
> > b/drivers/thermal/rockchip_thermal.c
> > index e227a9f0acf7..35554d146b9d 100644
> > --- a/drivers/thermal/rockchip_thermal.c
> > +++ b/drivers/thermal/rockchip_thermal.c
> > @@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(struct 
> > chip_tsadc_table table,
> >       }
> >     exit:
> > -    pr_err("Invalid the conversion, error=%d\n", error);
> > +    pr_err("%s: invalid temperature, temp=%d error=%d\n",
> > +        __func__, temp, error);
>
> I have do some similar for rockchip inside thermal driver.  Forget to 
> send for upstream. :(
> exit:
>     pr_err("%s: Invalid conversion table: code=%d, temperature=%d\n",
>            __func__, error, temp);
>
> >       return error;
> >   }
> >   @@ -475,7 +476,9 @@ static int rk_tsadcv2_code_to_temp(struct 
> > chip_tsadc_table table, u32 code,
> >           }
> >           break;
> >       default:
> > -        pr_err("Invalid the conversion table\n");
> > +        pr_err("%s: invalid conversion table, mode=%d\n",
> > +            __func__, table.mode);
> > +        return -EINVAL;

CHECK: Alignment should match open parenthesis
#428: FILE: drivers/thermal/rockchip_thermal.c:428:
+    pr_err("%s: invalid temperature, temp=%d error=%d\n",
+        __func__, temp, error);

CHECK: Alignment should match open parenthesis
#480: FILE: drivers/thermal/rockchip_thermal.c:480:
+        pr_err("%s: invalid conversion table, mode=%d\n",
+            __func__, table->mode);


I'm ready to resend all rockchip thermal patches. (contain them)

> >       }
> >         /*
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-rockchip