Re: [PATCH] zram: Fix unbalanced idr management at hot removal

From: Takashi Iwai
Date: Tue Nov 22 2016 - 00:52:28 EST


On Tue, 22 Nov 2016 02:39:13 +0100,
Sergey Senozhatsky wrote:
>
> On (11/22/16 10:33), Minchan Kim wrote:
> > On Tue, Nov 22, 2016 at 10:28:12AM +0900, Sergey Senozhatsky wrote:
> > > On (11/22/16 10:22), Minchan Kim wrote:
> > > [..]
> > > > > > Acked-by: Minchan Kim <minchan@xxxxxxxxxx>
> > > > >
> > > > > Link: lkml.kernel.org/r/20161121132140.12683-1-tiwai@xxxxxxx
> > > > > Fixes: 17ec4cd98578 ("zram: don't call idr_remove() from zram_remove()")
> > > > > Cc: <stable@xxxxxxxxxxxxxxx> [4.5+]
> > > >
> > > > 17ec4cd98578 marked as stable: [4.2+] so we should mark this patch as
> > > > 4.2+.
> > >
> > > well, no objections. except that the patch in question was
> > > not picked up -stable
> > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.2#n1365
> > >
> > > the change appears starting from 4.5
> > > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.5#n1371
>
>
> > https://git.kernel.org/cgit/linux/kernel/git/stable/linux-stable.git/tree/drivers/block/zram/zram_drv.c?id=refs/tags/v4.4.34#n1370
>
> oh, ok. good find. 4.4+ then? there are no affected stable/longterm
> kernels older than 4.4.x anyway (4.1 lts has no dynamic zram management).

Right, at least, 4.4.x hits the issue (actually the original bug
report was for 4.4.x).


thanks,

Takashi