Re: [PATCH] spi: spi-ti-qspi: reinit of completion variable

From: prahlad venkata
Date: Tue Nov 22 2016 - 02:24:32 EST


Did anybody got chance to review this patch?
I feel this is a trivial yet required fix.

On Tue, Nov 15, 2016 at 11:56 PM, Prahlad V <prahlad.eee@xxxxxxxxx> wrote:
>
> completion variable should be reinitialized before reusing.
>
> Signed-off-by: Prahlad V <prahlad.eee@xxxxxxxxx>
> ---
> drivers/spi/spi-ti-qspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-ti-qspi.c b/drivers/spi/spi-ti-qspi.c
> index caeac66..ec6fb09 100644
> --- a/drivers/spi/spi-ti-qspi.c
> +++ b/drivers/spi/spi-ti-qspi.c
> @@ -411,6 +411,7 @@ static int ti_qspi_dma_xfer(struct ti_qspi *qspi, dma_addr_t dma_dst,
> tx->callback = ti_qspi_dma_callback;
> tx->callback_param = qspi;
> cookie = tx->tx_submit(tx);
> + reinit_completion(&qspi->transfer_complete);
>
> ret = dma_submit_error(cookie);
> if (ret) {
> --
> 2.9.2.729.ga42d7b6
>



--
Regards,
Prahlad.
+91-9663742838