Re: commit 4dd1837d7589f468ed109556513f476e7a7f9121 breaks build
From: Arnd Bergmann
Date: Tue Nov 22 2016 - 06:12:16 EST
On Sunday, November 20, 2016 5:22:48 PM CET Russell King - ARM Linux wrote:
> - not touching:
> arch/arm/lib/csumpartialcopy.S
> arch/arm/lib/csumpartialcopygeneric.S
> arch/arm/lib/csumpartialcopyuser.S
>
> other than that, it's doing the same thing.
>
> I think Arnd's changes to the csumpartial code are unnecessary, and
> yours is, although larger, puts the asm/export.h include in the right
> place. So please drop yours into the patch system so we can move
> forward fixing some of the problems created during the last merge
> window.
Right, the csumpartialcopy*.S changes are no longer needed after
commit cc6acc11cad1 ("kbuild: be more careful about matching
preprocessed asm ___EXPORT_SYMBOL") solves the problem more
generally.
I've submitted a new version of my patch, now just adding the
one header file that is needed to get MODVERSIONS back working,
plus the second patch for mmiocpy/mmioset to partially revert
Al's original change.
Arnd