Re: [PATCH] orangefs: Axe some dead code

[Martin Brandenburg]

On Mon, 21 Nov 2016, Christophe JAILLET wrote:

> The "perf_counter_reset" case has already been handled above.
> Moreover "ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE" is not a really
> consistent.
> It is likely that this (dead) code is a cut and paste left over.

That's exactly what this is.

Reviewed-by: Martin Brandenburg <martin@xxxxxxxxxxxx>

> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>
> ---
>  fs/orangefs/orangefs-sysfs.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/fs/orangefs/orangefs-sysfs.c b/fs/orangefs/orangefs-sysfs.c
> index a799546a67f7..084954448f18 100644
> --- a/fs/orangefs/orangefs-sysfs.c
> +++ b/fs/orangefs/orangefs-sysfs.c
> @@ -609,15 +609,6 @@ static ssize_t sysfs_service_op_store(struct kobject *kobj,
>  			new_op->upcall.req.param.u.value32[0] = val1;
>  			new_op->upcall.req.param.u.value32[1] = val2;
>  			goto value_set;
> -		} else if (!strcmp(attr->attr.name,
> -				   "perf_counter_reset")) {
> -			if ((val > 0)) {
> -				new_op->upcall.req.param.op =
> -				ORANGEFS_PARAM_REQUEST_OP_READAHEAD_COUNT_SIZE;
> -			} else {
> -				rc = 0;
> -				goto out;
> -			}
>  		}
>  
>  	} else if (!strcmp(kobj->name, ACACHE_KOBJ_ID)) {
> -- 
> 2.9.3
> 
>