Re: [PATCH 1/5] mm: migrate: Add mode parameter to support additional page copy routines.

From: kbuild test robot
Date: Tue Nov 22 2016 - 14:57:27 EST


Hi Zi,

[auto build test WARNING on linus/master]
[also build test WARNING on v4.9-rc6 next-20161122]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Zi-Yan/Parallel-hugepage-migration-optimization/20161123-022913
reproduce:
# apt-get install sparse
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

include/linux/compiler.h:253:8: sparse: attribute 'no_sanitize_address': unknown attribute
>> fs/f2fs/data.c:1938:26: sparse: not enough arguments for function migrate_page_copy
fs/f2fs/data.c: In function 'f2fs_migrate_page':
fs/f2fs/data.c:1938:2: error: too few arguments to function 'migrate_page_copy'
migrate_page_copy(newpage, page);
^~~~~~~~~~~~~~~~~
In file included from fs/f2fs/data.c:1893:0:
include/linux/migrate.h:45:13: note: declared here
extern void migrate_page_copy(struct page *newpage, struct page *page,
^~~~~~~~~~~~~~~~~

vim +1938 fs/f2fs/data.c

5b7a487c Weichao Guo 2016-09-20 1922 if (atomic_written) {
5b7a487c Weichao Guo 2016-09-20 1923 struct inmem_pages *cur;
5b7a487c Weichao Guo 2016-09-20 1924 list_for_each_entry(cur, &fi->inmem_pages, list)
5b7a487c Weichao Guo 2016-09-20 1925 if (cur->page == page) {
5b7a487c Weichao Guo 2016-09-20 1926 cur->page = newpage;
5b7a487c Weichao Guo 2016-09-20 1927 break;
5b7a487c Weichao Guo 2016-09-20 1928 }
5b7a487c Weichao Guo 2016-09-20 1929 mutex_unlock(&fi->inmem_lock);
5b7a487c Weichao Guo 2016-09-20 1930 put_page(page);
5b7a487c Weichao Guo 2016-09-20 1931 get_page(newpage);
5b7a487c Weichao Guo 2016-09-20 1932 }
5b7a487c Weichao Guo 2016-09-20 1933
5b7a487c Weichao Guo 2016-09-20 1934 if (PagePrivate(page))
5b7a487c Weichao Guo 2016-09-20 1935 SetPagePrivate(newpage);
5b7a487c Weichao Guo 2016-09-20 1936 set_page_private(newpage, page_private(page));
5b7a487c Weichao Guo 2016-09-20 1937
5b7a487c Weichao Guo 2016-09-20 @1938 migrate_page_copy(newpage, page);
5b7a487c Weichao Guo 2016-09-20 1939
5b7a487c Weichao Guo 2016-09-20 1940 return MIGRATEPAGE_SUCCESS;
5b7a487c Weichao Guo 2016-09-20 1941 }
5b7a487c Weichao Guo 2016-09-20 1942 #endif
5b7a487c Weichao Guo 2016-09-20 1943
eb47b800 Jaegeuk Kim 2012-11-02 1944 const struct address_space_operations f2fs_dblock_aops = {
eb47b800 Jaegeuk Kim 2012-11-02 1945 .readpage = f2fs_read_data_page,
eb47b800 Jaegeuk Kim 2012-11-02 1946 .readpages = f2fs_read_data_pages,

:::::: The code at line 1938 was first introduced by commit
:::::: 5b7a487cf32d3a266fea83d590d3226b5ad817a7 f2fs: add customized migrate_page callback

:::::: TO: Weichao Guo <guoweichao@xxxxxxxxxx>
:::::: CC: Jaegeuk Kim <jaegeuk@xxxxxxxxxx>

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation