Re: drivers/bluetooth/dtl1_cs.c:559: bad if statement ?

From: Marcel Holtmann
Date: Tue Nov 22 2016 - 16:49:48 EST


Hi David,

> drivers/bluetooth/dtl1_cs.c:559:32: warning: logical âorâ of collectively exhaustive tests is always true [-Wlogical-op]
>
> Source code is
>
> if ((p_dev->resource[1]->end) || (p_dev->resource[1]->end < 8))
> return -ENODEV;
>
> Maybe better code
>
> if ((p_dev->resource[1]->end < 0) || (p_dev->resource[1]->end >= 8))
> return -ENODEV;

mind sending a patch?

Regards

Marcel