Re: [PATCH] mtd: mtdswap: fix spelling mistake "erassure" -> "erasure"
From: Brian Norris
Date: Tue Nov 22 2016 - 17:46:28 EST
On Tue, Nov 22, 2016 at 01:32:27PM -0800, Joe Perches wrote:
> On Tue, 2016-11-22 at 11:37 -0800, Brian Norris wrote:
> > Thanks, these all look good but:
> >
> > (a) you didn't provide a Signed-off-by and
> > (b) your patch is full of non-breaking spaces (0xA0), instead of proper
> > ASCII spaces (0x20)
> >
> > I feel like we've had this conversation before about your Evolution
> > mailer a long time ago; you still haven't fixed that?
> >
> > I'm sorry, but I just can't take your patch. I'm not going to hand-edit
> > this one...
>
> No worries, it was an unsigned patch suggestion, not
> a formal patch. I know the difference.
OK, understood.
> And have you ever looked at the evolution source code?
> At best, it's pretty convoluted.
> There's _no way_ I want to touch it.
I haven't looked. But by "fixed" I guess I meant "fixed your workflow" :)
Regards,
Brian