Re: [PATCH] dt-bindings: mfd: Improve readability for TPS65217 interrupt sources

From: Milo Kim
Date: Wed Nov 23 2016 - 08:06:35 EST


On 11/23/2016 08:51 PM, Arnd Bergmann wrote:
Ah, the numbers come from the data sheet. Please just remove the
header then, there is no need to keep them as an ABI, in particular
when the driver doesn't even include that header today.

Got it.

What matters here is the binding documentation in
Documentation/devicetree/bindings/power/supply/tps65217_charger.txt

OK, in addition to this, the interrupt specifier needs to be added in Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt.

Please fix that instead to mandate that the two interrupts are
required, what their functions are, and what the interrupt-names
(not interrupts-names) property must list.

Oops, wrong interrupt name property - my bad.

Thanks for all your feedback.

Best regards,
Milo