Re: [PATCH 2/3] pinctrl: New driver for TI DA8XX/OMAP-L138/AM18XX pinconf

From: David Lechner
Date: Wed Nov 23 2016 - 11:21:47 EST


On 11/23/2016 05:04 AM, Sekhar Nori wrote:
On Wednesday 23 November 2016 08:59 AM, David Lechner wrote:
This adds a new driver for pinconf on TI DA8XX/OMAP-L138/AM18XX. These

s/DA8XX/DA850/

SoCs have a separate controller for controlling pullup/pulldown groups.

Signed-off-by: David Lechner <david@xxxxxxxxxxxxxx>

+static const char *da850_pupd_get_get_group_name(struct pinctrl_dev *pctldev,
+ unsigned int selector)
+{
+ return da850_pupd_group_names[selector];
+}
+
+static int da850_pupd_get_get_group_pins(struct pinctrl_dev *pctldev,
+ unsigned int selector,
+ const unsigned int **pins,
+ unsigned int *num_pins)
+{
+ *num_pins = 0;
+
+ return 0;
+}

usage of get_get_ in the function names above is odd.

Will fix (copy/paste error)


Thanks,
Sekhar