Re: [PATCH 01/14] perf/x86: Introduce PERF_RECORD_OVERHEAD

From: Peter Zijlstra
Date: Wed Nov 23 2016 - 15:13:35 EST


On Wed, Nov 23, 2016 at 04:44:39AM -0500, kan.liang@xxxxxxxxx wrote:
> +/*
> + * single overhead record layout:
> + *
> + * cpu: The cpu which overhead occues

This is duplicate information, its already present in sample_id when
PERF_SAMPLE_CPU, and without that we don't care.

> + * nr: Times of overhead happens.
> + * E.g. for NMI, nr == times of NMI handler are called.
> + * time: Total overhead cost(ns)
> + */
> +struct perf_overhead_entry {
> + __u32 cpu;
> + __u64 nr;
> + __u64 time;
> +};