Re: [PATCH V2 3/4] cpufreq: schedutil: move slow path from workqueue to SCHED_FIFO task
From: Viresh Kumar
Date: Thu Nov 24 2016 - 00:10:52 EST
On 24-11-16, 05:51, Ingo Molnar wrote:
>
> * Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
>
> > + /*
> > + * For Real Time and Deadline tasks, schedutil governor shoots the
> > + * frequency to maximum. And special care must be taken to ensure that
> > + * this kthread doesn't result in that.
> > + *
> > + * This is (mostly) guaranteed by the work_in_progress flag. The flag is
> > + * updated only at the end of the sugov_work() and before that schedutil
> > + * rejects all other frequency scaling requests.
> > + *
> > + * Though there is a very rare case where the RT thread yields right
> > + * after the work_in_progress flag is cleared. The effects of that are
> > + * neglected for now.
> > + */
>
> s/schedutil governor/
> the schedutil governor
>
> s/And special care must be taken/
> Special care must be taken
>
> s/at the end of the sugov_work()/
> at the end of the sugov_work() function
>
> s/before that schedutil rejects/
> before the schedutil governor rejects
>
> s/Though there is a very rare case where
> There is a very rare case though, where
Thanks. I will send a fix for this.
--
viresh