Re: [PATCH] usb: xhci: Remove unuseful 'return' statement

From: Sergei Shtylyov
Date: Thu Nov 24 2016 - 04:30:17 EST


Hello.

On 11/24/2016 11:13 AM, Baolin Wang wrote:

Since these 'return' statements are not generally useful in void function,
remove them.

Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx>
[...]
diff --git a/drivers/usb/host/xhci-mem.c b/drivers/usb/host/xhci-mem.c
index 48a26d378..d6f59a3 100644
--- a/drivers/usb/host/xhci-mem.c
+++ b/drivers/usb/host/xhci-mem.c
@@ -1146,7 +1146,6 @@ int xhci_setup_addressable_virt_dev(struct xhci_hcd *xhci, struct usb_device *ud
case USB_SPEED_WIRELESS:
xhci_dbg(xhci, "FIXME xHCI doesn't support wireless speeds\n");
return -EINVAL;
- break;

Here you're removing *break* instead but not mentioning this in the patch description...

[...]

MBR, Sergei