Re: [PATCH 2/3] iio: st_accel: Support sensor i2c probe using acpi

[Linus Walleij]

On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
<shrirang.bagul@xxxxxxxxxxxxx> wrote:

> Add support to probe st_accel sensors on i2c bus using ACPI. Compatible
> strings are not avaialable on ACPI based systems.
>
> Signed-off-by: Shrirang Bagul <shrirang.bagul@xxxxxxxxxxxxx>
(...)

> +#ifdef CONFIG_ACPI
> +static const struct acpi_device_id st_accel_acpi_match[] = {
> +       {"SMO8A90", LNG2DM},
> +       { },
> +};

Why is ACPI only supporting one out of 14 devices?

Surely there are some out-of-tree ACPI platforms using one
or more of the others?

Apart from that it looks nice.

Yours,
Linus Walleij