Re: [PATCH 2/6] dax: remove leading space from labels

From: Dan Williams
Date: Thu Nov 24 2016 - 14:43:32 EST


On Thu, Nov 24, 2016 at 1:11 AM, Jan Kara <jack@xxxxxxx> wrote:
> On Wed 23-11-16 11:44:18, Ross Zwisler wrote:
>> No functional change.
>>
>> As of this commit:
>>
>> commit 218dd85887da (".gitattributes: set git diff driver for C source code
>> files")
>>
>> git-diff and git-format-patch both generate diffs whose hunks are correctly
>> prefixed by function names instead of labels, even if those labels aren't
>> indented with spaces.
>
> Fine by me. I just have some 4 remaining DAX patches (will send them out
> today) and they will clash with this. So I'd prefer if this happened after
> they are merged...

Let's just leave them alone, it's not like this thrash buys us
anything at this point. We can just stop including spaces in new
code.