Re: [PATCH] Lock down drivers that can have io ports, io mem, irqs and dma changed

[Dominik Brodowski]

On Thu, Nov 24, 2016 at 05:34:45PM +0000, David Howells wrote:
> Dominik Brodowski <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> 
> > > > 	- Abort in drivers/pcmcia/cistpl.c::pccard_store_cis() or remove
> > > > 	  write access to the "cis" file in
> > > > 	  drivers/pcmcia/cistpl.c::pccard_cis_attr
> > > 
> > > What is that doing?  Allowing the device to be reconfigured?
> > 
> > Exactly. It is a different interface for updating the firmware -- which
> > includes ioports etc. In theory, any access should be limited to areas which
> > are registered to the bridge devices. But you never know...
> 
> Ah, I see.  Should this be using request_firmware()?

For most cases, request_firmware() is being used -- for some rare cases,
however, this alternative interface is provided for. It should be pretty
safe nowadays to make pccard_cis_attr read-only (and who uses PCMCIA
nowadays anyway?).

Best,
	Dominik