Re: [PATCH 0/7] overlayfs: fix ro/rw fd data inconsistecies

From: Amir Goldstein
Date: Thu Nov 24 2016 - 15:50:56 EST


On Thu, Nov 24, 2016 at 4:14 PM, Miklos Szeredi <miklos@xxxxxxxxxx> wrote:
> On Thu, Nov 24, 2016 at 11:55 AM, Miklos Szeredi <mszeredi@xxxxxxxxxx> wrote:
>> A file is opened for read-only, opened read-write (resulting in a copy up)
>> and modified. The data read back from the the read-only fd will be stale
>> in this case (the read-only file descriptor still refers to the lower,
>> unmodified file).
>>
>> This patchset fixes issues related to this corner case.
>>
>> The VFS impact is minimal and performance in the non-corner cases shouldn't
>> suffer.
>
> Git tree is here:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git #overlayfs-rorw
>

passed my tests.
I now run all my tests (including unionmount-testsuite) on a setup of
overlayfs over xfs with reflink:
- xfstests - from my github overlayfs-devel branch
-g quick and overlay/*
including new test 016 to check ro/rw fd data inconsistencies
- pjdfstest - from my github overlayfs-devel branch
including acl/xattr tests
- unionmount-testsuite - from my github overlayfs-devel branch
without recycling (--ov), with mount recycle -(-ov=0) and with mount
recycle and
layers (--ov=10)

Tested-by: Amir Goldstein <amir73il@xxxxxxxxx>