Re: [tip:x86/core] x86: Enable Intel Turbo Boost Max Technology 3.0

From: Ingo Molnar
Date: Fri Nov 25 2016 - 03:20:02 EST

* tip-bot for Tim Chen <tipbot@xxxxxxxxx> wrote:

> Commit-ID: 5e76b2ab36b40ca33023e78725bdc69eafd63134
> Gitweb:
> Author: Tim Chen <tim.c.chen@xxxxxxxxxxxxxxx>
> AuthorDate: Tue, 22 Nov 2016 12:23:55 -0800
> Committer: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> CommitDate: Thu, 24 Nov 2016 20:44:19 +0100
> x86: Enable Intel Turbo Boost Max Technology 3.0

This patch doesn't build:

Note that this patch has to be redone anyway, as it won't even build:

> +#include <linux/sched.h>
> +#include <linux/cpumask.h>
> +#include <linux/cpuset.h>
> +#include <asm/mutex.h>
> +#include <linux/sched.h>
> +#include <linux/sysctl.h>
> +#include <linux/nodemask.h>

arch/x86/kernel/itmt.c:26:23: fatal error: asm/mutex.h: No such file or directory

> +config SCHED_ITMT
> + bool "Intel Turbo Boost Max Technology (ITMT) scheduler support"
> + depends on SCHED_MC && CPU_SUP_INTEL && X86_INTEL_PSTATE
> + ---help---
> + ITMT enabled scheduler support improves the CPU scheduler's decision
> + to move tasks to cpu core that can be boosted to a higher frequency
> + than others. It will have better performance at a cost of slightly
> + increased overhead in task migrations. If unsure say N here.

Argh, so the 'itmt' name really sucks as well - could we please make it something
more obvious - like SCHED_INTEL_TURBO or so - and similarly rename the file as

The sched_intel_turbo.c file could thus host all things related to scheduler
support of turbo frequencies - it shouldn't be named after the Intel acronym of
the day...