Re: next: s390 crash due to 's390: move sys_call_table and last_break from thread_info to thread_struct'

[Martin Schwidefsky]

Hi Guenter,

On Thu, 24 Nov 2016 12:53:52 -0800
Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

> > Thanks for the report. Builds for Z900 and Z990 are borked. This hunk
> >
> > @@ -287,7 +292,13 @@ ENTRY(system_call)
> >         mvc     __PT_INT_CODE(4,%r11),__LC_SVC_ILC
> >         stg     %r14,__PT_FLAGS(%r11)
> >  .Lsysc_do_svc:
> > -       lg      %r10,__TI_sysc_table(%r12)      # address of system call table
> > +       # load address of system call table
> > +#ifdef CONFIG_HAVE_MARCH_Z990_FEATURES
> > +       lg      %r10,__TASK_thread+__THREAD_sysc_table(%r12)
> > +#else
> > +       lghi    %r10,__TASK_thread
> > +       lg      %r10,__THREAD_sysc_table(%r10,%r12)
> > +#endif
> >         llgh    %r8,__PT_INT_CODE+2(%r11)
> >         slag    %r8,%r8,2                       # shift and test for svc 0
> >         jnz     .Lsysc_nr_ok
> >
> > makes ill use of %r10 in the #else part. Should be fixed now and tomorrows -next
> > tree will have the fix. Thanks again.
> >
> 
> This is still crashing in -next with exactly the same message.

Yes, it is (note to myself: don't do things in a hurry). The patch below
gets linux-next booting again for CONFIG_MARCH_Z900=y on my test system.
Sorry about the trouble.

--