Re: [PATCH 0/3] virtio/vringh: kill off ACCESS_ONCE()

From: Peter Zijlstra
Date: Fri Nov 25 2016 - 07:44:24 EST


On Fri, Nov 25, 2016 at 01:40:44PM +0100, Peter Zijlstra wrote:
> #define SINGLE_LOAD(x) \
> {( \
> compiletime_assert_atomic_type(typeof(x)); \

Should be:

compiletime_assert_atomic_type(x);

> WARN_SINGLE_COPY_ALIGNMENT(&(x)); \
> READ_ONCE(x); \
> })
>
> #define SINGLE_STORE(x, v) \
> ({ \
> compiletime_assert_atomic_type(typeof(x)); \

idem

> WARN_SINGLE_COPY_ALIGNMENT(&(x)); \
> WRITE_ONCE(x, v); \
> })