Re: [PATCH] ovl: tentative fix for broken vfs_open() on stacked overlayfs.

From: Quentin Casasnovas
Date: Fri Nov 25 2016 - 14:24:28 EST


On Fri, Nov 25, 2016 at 06:09:23PM +0100, Quentin Casasnovas wrote:
> If two overlayfs filesystems are stacked on top of each other, then we need
> to recurse when opening a file. This used to work and was first broken by:
>
> 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay...")
>
> and fixed by:
>
> 1c8a47df36d7 ("ovl: fix open in stacked overlay")
>
> But it looks like it was re-introduced in:
>
> 2d902671ce1c ("vfs: merge .d_select_inode() into .d_real()")
>
> I know close to nothing about VFS/overlayfs

And indeed I've proven it here - this tentative patch doesn't work for the
general case, it just fixes the simple test case embedded in the commit
description.

Any help appreciated!
Q

Attachment: signature.asc
Description: Digital signature