Re: [PATCH] xen-scsifront: Add a missing call to kfree

From: Dan Carpenter
Date: Fri Nov 25 2016 - 16:29:35 EST


On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote:
> On 19/11/16 19:22, Quentin Lambert wrote:
> > Most error branches following the call to kmalloc contain
> > a call to kfree. This patch add these calls where they are
> > missing.
> >
> > This issue was found with Hector.
> >
> > Signed-off-by: Quentin Lambert <lambert.quentin@xxxxxxxxx>
>
> Nice catch. I think this will need some more work, I'll do a
> follow-on patch.

Yeah. It's weird how we free it on the success path and all the failure
paths except one. But it looks so deliberate. What's going on with
that?

Could you send your follow on patch as a reply to the thread?

regards,
dan carpenter