Re: module: extend 'rodata=off' boot cmdline parameter to module mappings

[Rusty Russell]

Jessica Yu <jeyu@xxxxxxxxxx> writes:

> +++ AKASHI Takahiro [14/11/16 15:15 +0900]:
>>The current "rodata=off" parameter disables read-only kernel mappings
>>under CONFIG_DEBUG_RODATA:
>>    commit d2aa1acad22f ("mm/init: Add 'rodata=off' boot cmdline parameter
>>    to disable read-only kernel mappings")
>>
>>This patch is a logical extension to module mappings ie. read-only mappings
>>at module loading can be disabled even if CONFIG_DEBUG_SET_MODULE_RONX
>>(mainly for debug use). Please note, however, that it only affects RO/RW
>>permissions, keeping NX set.
>>
>>This is the first step to make CONFIG_DEBUG_SET_MODULE_RONX mandatory
>>(always-on) in the future as CONFIG_DEBUG_RODATA on x86 and arm64.
>>
>>Suggested-by: and Acked-by: Mark Rutland <mark.rutland@xxxxxxx>
>>Signed-off-by: AKASHI Takahiro <takahiro.akashi@xxxxxxxxxx>
>>Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
>>Cc: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
>
> Hi Rusty, could I get an (n)ack for this patch? :-)

Acked-by: Rusty Russell <rusty@xxxxxxxxxxxxxxx>

Cheers,
Rusty.