Re: [PATCH V4 2/2] pinctrl: tegra: Add driver to configure voltage and power of io pads

From: Laxman Dewangan
Date: Mon Nov 28 2016 - 04:39:20 EST



On Monday 28 November 2016 02:56 PM, Jon Hunter wrote:
On 25/11/16 17:49, Laxman Dewangan wrote:

In the above dpaux driver, you used the pinctrl framework and its core
functionality for the device tree interfacing and client interfacing.

The same thing I am saying here, we should not avoid the pinctrl
framework. The client driver will use the pinctrl framework for the IO
pad configurations, not direct PMC APIs.
Exactly, so why are you saying that by moving the code into the PMC
driver this will "need lots of DT processing for getting information
from DT"? By moving the code, we are not suggesting we don't use the
pinctrl framework, we are just suggesting we move the code. That's all.


OK, got it. My understanding from suggestion was that to implement everything without using the pinctrl framework.

I dont see much issue to just move this to drivers/soc/tegra folder
I hope rest of stuff will be same, registering it as subdev of the pmc and this io pad driver will be the platform driver.