Re: [PATCH v2] usb: xhci: Remove unuseful 'return' and 'break' statement

From: Mathias Nyman
Date: Mon Nov 28 2016 - 10:16:25 EST

On 28.11.2016 09:41, Baolin Wang wrote:
On 28 November 2016 at 15:21, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
On Mon, Nov 28, 2016 at 02:29:25PM +0800, Baolin Wang wrote:
Hi Mathias,

On 24 November 2016 at 19:16, Baolin Wang <> wrote:
Since these 'return' statements are not generally useful in void
function, remove them. Also remove one unuseful 'break' statement
in xhci_setup_addressable_virt_dev() function.

Signed-off-by: Baolin Wang <>
Changes since v1:
- Add description of removing 'break' statement in commitlog.

Could you apply this patch if there are no other comments? Thanks.

Less than a week response for a simple cleanup patch? Why the rush and
pressure? Relax, this really isn't an important patch...

I am sorry for the pressure, I just thought it is one simple cleanup
patch. It is okay for me to wait for.

Looks ok.

If it applies I'll send it forward to usb-next after 4.10-rc1,
It should end up in 4.11