Re: [PATCH] drm/virtio: fix framebuffer sparse warning

From: Michael S. Tsirkin
Date: Mon Nov 28 2016 - 10:28:34 EST


On Mon, Nov 28, 2016 at 09:05:21AM +0100, Gerd Hoffmann wrote:
> virtio uses normal ram as backing storage for the framebuffer, so we
> should assign the address to new screen_buffer (added by commit
> 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base.
>
> Reported-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>

Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx>

> ---
> drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c
> index 2242a80..dc2976c 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_fb.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c
> @@ -337,7 +337,7 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper,
> info->fbops = &virtio_gpufb_ops;
> info->pixmap.flags = FB_PIXMAP_SYSTEM;
>
> - info->screen_base = obj->vmap;
> + info->screen_buffer = obj->vmap;
> info->screen_size = obj->gem_base.size;
> drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
> drm_fb_helper_fill_var(info, &vfbdev->helper,
> --
> 1.8.3.1