Re: [PATCH 2/2] mremap: use mmu gather logic for tlb flush in mremap

From: Linus Torvalds
Date: Mon Nov 28 2016 - 12:42:17 EST


On Mon, Nov 28, 2016 at 9:32 AM, Dave Hansen <dave.hansen@xxxxxxxxx> wrote:
>
> But, both call-sites are still keeping 'force_flush' to store the
> information about whether we ever saw a dirty pte. If we moved _that_
> logic into the x86 mmu_gather code, we could get rid of all the
> 'force_flush' tracking in both call sites. It also makes us a bit more
> future-proof against these page_mkclean() races if we ever grow a third
> site for clearing ptes.

Yeah, that sounds like a nice cleanup and would put all the real state
into that mmu_gather structure.

Linus