Re: [PATCH 1/1] libnvdimm, namespace: fix the type of name variable

From: Ross Zwisler
Date: Mon Nov 28 2016 - 16:26:38 EST


On Sat, Nov 26, 2016 at 08:18:04PM +0100, Nicolas Iooss wrote:
> In create_namespace_blk(), the local variable "name" is defined as an
> array of NSLABEL_NAME_LEN pointers:
>
> char *name[NSLABEL_NAME_LEN];
>
> This variable is then used in calls to memcpy() and kmemdup() as if it
> were char[NSLABEL_NAME_LEN]. Remove the star in the variable definition
> to makes it look right.
>
> Signed-off-by: Nicolas Iooss <nicolas.iooss_linux@xxxxxxx>

Yep, nice catch.

Reviewed-by: Ross Zwisler <ross.zwisler@xxxxxxxxxxxxxxx>