Re: [f2fs-dev] [PATCH 2/2] f2fs: fix wrong AUTO_RECOVER condition

From: Jaegeuk Kim
Date: Mon Nov 28 2016 - 19:31:49 EST


On Fri, Nov 25, 2016 at 11:40:58PM +0800, Chao Yu wrote:
> Hi Jaegeuk,
>
> isize AUTO_RECOVER still be corrupted..., try below case:
>
> 1. xfs_io -f /mnt/f2fs/file -c "pwrite 0 4096" -c "fsync"
> 2. xfs_io -f /mnt/f2fs/file -c "falloc -k 4096 4096" -c "fsync"
> 3. md5sum /mnt/f2fs/file;
> 4. godown /mnt/f2fs/
> 5. umount /mnt/f2fs/
> 6. mount -t f2fs /dev/sdx /mnt/f2fs
> 7. md5sum /mnt/f2fs/file
>
> It's hard to deside to recover isize or not when current recovered block is
> fallocated, as we can allocate block inside or outside of isize.
>
> Any thoughts?

Could you take a look at this patch?