Re: [PATCH 2/3] iio: st_accel: Support sensor i2c probe using acpi

[Shrirang Bagul]

On Sun, 2016-11-27 at 11:14 +0000, Jonathan Cameron wrote:
> On 24/11/16 14:26, Linus Walleij wrote:
> > On Thu, Nov 24, 2016 at 6:33 AM, Shrirang Bagul
> > <shrirang.bagul@xxxxxxxxxxxxx> wrote:
> > 
> > > Add support to probe st_accel sensors on i2c bus using ACPI. Compatible
> > > strings are not avaialable on ACPI based systems.
> > > 
> > > Signed-off-by: Shrirang Bagul <shrirang.bagul@xxxxxxxxxxxxx>
> > 
> > (...)
> > 
> > > +#ifdef CONFIG_ACPI
> > > +static const struct acpi_device_id st_accel_acpi_match[] = {
> > > +ÂÂÂÂÂÂÂ{"SMO8A90", LNG2DM},
> > > +ÂÂÂÂÂÂÂ{ },
> > > +};
> > 
> > Why is ACPI only supporting one out of 14 devices?
> > 
> > Surely there are some out-of-tree ACPI platforms using one
> > or more of the others?
> > 
> > Apart from that it looks nice.
> 
> Applied to the togreg branch of iio.git and pushed out as testing
> for the autobuilders to play with it.
> 
> Anyone know where the ACPI names come from? Is there some big
> list somewhere to prevent clashes?
> 
> Jonathan
I'll take a look at the HW in our lab and send patches to identify more st_accel
sensors used mostly on Dell laptops.

Shrirang
> > 
> > Yours,
> > Linus Walleij
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> > the body of a message to majordomo@xxxxxxxxxxxxxxx
> > More majordomo info atÂÂhttp://vger.kernel.org/majordomo-info.html
> > 
> 
>