Re: [PATCH] lockdep: fix report formatting

From: Andrew Donnellan
Date: Tue Nov 29 2016 - 02:50:23 EST


On 29/11/16 01:24, Dmitry Vyukov wrote:
Since commit 4bcc595ccd80 ("printk: reinstate KERN_CONT for printing
continuation lines") printk() requires KERN_CONT to continue log
messages. Lots of printk() in lockdep.c and print_ip_sym() don't
have it. As the result lockdep reports are completely messed.

Add missing KERN_CONT and inline print_ip_sym() where necessary.

Without this patch all scripts that parse kernel bug reports
are broken. So it makes sense to get this into 4.9.

I'm glad someone else is looking at this, I started working on a similar patch but haven't quite finished it :)


Cc: aryabinin@xxxxxxxxxxxxx
Cc: andreyknvl@xxxxxxxxxx
Cc: joe@xxxxxxxxxxx
Cc: peterz@xxxxxxxxxxxxx
Cc: mingo@xxxxxxxxxx
Cc: linux-kernel@xxxxxxxxxxxxxxx
Cc: syzkaller@xxxxxxxxxxxxxxxx

Missing Signed-off-by.

FWIW I think the pr_cont() macro looks nicer than printk(KERN_CONT ...).

--
Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx IBM Australia Limited