Re: [PATCH v2] platform/chrome: Use proper protocol transfer function

From: Javier Martinez Canillas
Date: Tue Nov 29 2016 - 07:21:32 EST


Hello Brian,

On 11/28/2016 07:19 PM, Brian Norris wrote:
> From: Shawn Nematbakhsh <shawnn@xxxxxxxxxxxx>
>
> pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had
> one instance of these functions correct, but not the second, fall-back
> case. We use the fall-back only when the first command returns an
> IN_PROGRESS status, which is only used on some EC firmwares where we
> don't want to constantly poll the bus, but instead back off and
> sleep/retry for a little while.
>

That's correct, sorry for missing this when pushing the patch to mainline.

Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
--
Javier Martinez Canillas
Open Source Group
Samsung Research America