Re: [PATCHv12 2/3] usb: USB Type-C connector class
From: Heikki Krogerus
Date: Tue Nov 29 2016 - 08:02:31 EST
Hi Guenter,
On Mon, Nov 28, 2016 at 12:11:43PM -0800, Guenter Roeck wrote:
> Personally I don't really care about a module parameter; as mentioned above,
> I would expect the preference, if it needs to be selectable, to be configured
> with devicetree or ACPI properties (or by a platform driver which sets a device
> property).
Unfortunately we can not assume the firmware to be always correct.
Companies love to recycle the firmware. We are going to see products
from a company X that should prefer source role, a desktop for
example, but still give the OS a device property that says otherwise.
The reason for that is most likely because the previous product from
that company was some kind of mobile device.
So IMHO we need some way for the OS to override this thing eventually.
If not module parameters, then something else. The other option is
board specific quirks, and I would really prefer to avoid those if we
can.
Thanks,
--
heikki