Re: [PATCH] clocksource/arm_global_timer: reconfigure clockevents after cpufreq change
From: Thomas Gleixner
Date: Tue Nov 29 2016 - 09:12:36 EST
On Tue, 29 Nov 2016, Alexander Kochetkov wrote:
> > 29 ÐÐÑÐ. 2016 Ð., Ð 16:42, Thomas Gleixner <tglx@xxxxxxxxxxxxx> ÐÐÐÐÑÐÐ(Ð):
> >
> > The frequency change would not only affect the clockevent device, it also
> > would affect the clocksource. So the patch is incomplete, but see below.
> Looks like kernel disallow change clocksource and shed_clock rate at
> runtime. I havenât found any function for that.
>
> > 29 ÐÐÑÐ. 2016 Ð., Ð 16:42, Thomas Gleixner <tglx@xxxxxxxxxxxxx> ÐÐÐÐÑÐÐ(Ð):
> >
> > That's broken and the clk framework should keep the CORE_PERI clock at a
> > constant rate by reprogramming the divider of the CPU clock.
>
> Thank you for the hint.
>
> > Assumptions w/o real impact are a perfect reason not to apply that
> > patch. This want's a proper proof that the global timer really changes and
> > this hackery is required, which I seriously doubt.
>
> It really changes. It changes like it changes for smp-twd. I guess they are
> driven by same clock CORE_PERI.
If that happens then the whole thing wants to be disabled on those
misconfigured systems and not just hacked for nothing.
Thanks,
tglx