Re: [PATCH V5] i2c: mux: pca954x: Add ACPI support for pca954x
From: Tin Huynh
Date: Tue Nov 29 2016 - 10:12:53 EST
On Tue, Nov 29, 2016 at 5:15 PM, Peter Rosin <peda@xxxxxxxxxx> wrote:
> On 2016-11-29 11:12, Tin Huynh wrote:
>> This patch enables ACPI support for mux-pca954x driver.
> Looks good, thanks!
>> Signed-off-by: Tin Huynh <tnhuynh@xxxxxxx>
> Acked-by: Peter Rosin <peda@xxxxxxxxxx>
However , in http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/drivers/gpio/gpio-pca953x.c?id=f32517bf1ae0a2de72b3f27200233bd3ad65bfeb
log , i didn't see the CONFIG_ACPI and CONFIG_PTR.
I have been acked with the same patch to support for i2c-leds (
About logic , if we don't enable CONFIG_ACPI , acpi_match_table will
be NULL . So , the probe functions will be not called
and nothing happens.
I though we should use V3 (https://lkml.org/lkml/2016/11/28/893)