Re: [PATCH 15/22] arm64/cpuinfo: Make hotplug notifier symmetric
From: Suzuki K Poulose
Date: Tue Nov 29 2016 - 12:24:29 EST
On 26/11/16 23:13, Sebastian Andrzej Siewior wrote:
From: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
There is no requirement to keep the sysfs files around until the CPU is
completely dead. Remove them during the DOWN_PREPARE notification. This is
a preparatory patch for converting to the hotplug state machine.
Cc: Catalin Marinas <catalin.marinas@xxxxxxx>
Cc: Will Deacon <will.deacon@xxxxxxx>
Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
---
arch/arm64/kernel/cpuinfo.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/cpuinfo.c b/arch/arm64/kernel/cpuinfo.c
index b3d5b3e8fbcb..19aad7041e14 100644
--- a/arch/arm64/kernel/cpuinfo.c
+++ b/arch/arm64/kernel/cpuinfo.c
@@ -272,9 +272,10 @@ static int cpuid_callback(struct notifier_block *nb,
switch (action & ~CPU_TASKS_FROZEN) {
case CPU_ONLINE:
+ case CPU_DOWN_FAILED:
rc = cpuid_add_regs(cpu);
break;
- case CPU_DEAD:
+ case CPU_DOWN_PREPARE:
rc = cpuid_remove_regs(cpu);
break;
}
Looks reasonable to me:
Reviewed-by : Suzuki K Poulose <suzuki.poulose@xxxxxxx>