Re: [PATCH v2] drivers/base: use READ_ONCE instead of deprecated ACCESS_ONCE
From: Greg KH
Date: Wed Nov 30 2016 - 08:54:41 EST
On Wed, Nov 30, 2016 at 05:49:26AM -0800, Davidlohr Bueso wrote:
> With the new standardized functions, we can replace all ACCESS_ONCE()
> calls across relevant drivers/base/.
> ACCESS_ONCE() does not work reliably on non-scalar types. For example
> gcc 4.6 and 4.7 might remove the volatile tag for such accesses during
> the SRA (scalar replacement of aggregates) step:
> Update the new calls regardless of if it is a scalar type, this is
> cleaner than having three alternatives.
> Signed-off-by: Davidlohr Bueso <dave@xxxxxxxxxxxx>
> drivers/base/core.c | 2 +-
> drivers/base/power/runtime.c | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
What changed from v1? Please always include it below the --- line to
keep maintainer's semi-sane.