Re: [RFC][PATCH 0/3] Try to connect hikey's usb phy to dwc2 driver

From: John Stultz
Date: Wed Nov 30 2016 - 20:36:10 EST


On Tue, Nov 22, 2016 at 7:46 PM, John Stultz <john.stultz@xxxxxxxxxx> wrote:
> After earlier attempts[1] at submitting somewhat hackish fixes
> to the dwc2 driver, I realized the core issue seemed to be the
> overly simplistic phy driver.
>
> I've connected the phy-hi6220-usb.c driver to extcon so it now
> gets connection and disconnection signals on the usb gadget
> cable. And I modified the driver so it registers a usb-phy and
> calls usb_gadget_vbus_connect/disconnect() appropriately.
>
> Unfortunately this doesn't quite work with the dwc2 driver,
> so I've hacked that driver to allow it to function.
>
> With these changes, while likely not correct, things function
> well, and I was able to drop two of the hackish fixups from the
> earlier set. I still needed one patch to keep the usb bus from
> suspending while in gadget mode, so I've included that in this
> series.
>
> [1]: http://www.mail-archive.com/linux-kernel@xxxxxxxxxxxxxxx/msg1272880.html
>
> Feedback and guidance would be greatly appreciated!
>
>
> John Stultz (3):
> phy: phy-hi6220-usb: Wire up extconn support to hikey's phy driver
> HACK: dwc2: force dual use of uphy and phy
> usb: dwc2: Avoid suspending if we're in gadget mode

Curious if there was any feedback on this patchset or the general approach?

thanks
-john