Re: [PATCH 1/1] block: mtip32xx: set error code on failure
From: Jens Axboe
Date: Thu Dec 01 2016 - 10:03:41 EST
On 11/30/2016 07:10 PM, Pan Bian wrote:
> Fix bug https://bugzilla.kernel.org/show_bug.cgi?id=188531. In function
> mtip_block_initialize(), variable rv takes the return value, and its
> value should be negative on errors. rv is initialized as 0 and is not
> reset when the call to ida_pre_get() fails. So 0 may be returned.
> The return value 0 indicates that there is no error, which may be
> inconsistent with the execution status. This patch fixes the bug by
> explicitly assigning -ENOMEM to rv on the branch that ida_pre_get()
> fails.
Thanks, applied for 4.10.
--
Jens Axboe