Re: [RFC] perf/x86/intel/uncore: pmu->type->single_fixed question

From: Peter Zijlstra
Date: Thu Dec 01 2016 - 11:38:48 EST


On Thu, Dec 01, 2016 at 04:34:43PM +0000, Liang, Kan wrote:
>
> >
> > "Liang, Kan" <kan.liang@xxxxxxxxx> writes:
> > >
> > > Maybe we should create a clocktick box for client uncore to fix it.
> >
> > That would break all the user space code that uses the existing format.
> >
> OK.
> If so, I think we should remove the non-exist events for non-first boxes.
>
> What do you think about the patch as below?
>
> Andi? Jirka?

Urgh, more lines for ugly :-(

I really would prefer to move the thing to its own PMU.