Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

[Tomasz Nowicki]

On 02.12.2016 07:42, Duc Dang wrote:
> On Thu, Dec 1, 2016 at 9:50 PM, Jon Masters <jcm@xxxxxxxxxx> wrote:
> > On 11/30/2016 07:28 PM, Bjorn Helgaas wrote:
> >
> > > I'm hoping to end up with something like this:
> > > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a66b346a46b21a785a2937469
> >
> > The following build warnings happen using your branch on RHELSA7.3:
> >
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> >   THUNDER_PEM_QUIRK(2,  0), /* off-chip devices */
> >   ^
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[44].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[44].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[45].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[45].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[46].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[46].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[47].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[47].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[48].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[48].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[49].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:101:2: warning: (near initialization for âmcfg_quirks[49].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> >   THUNDER_PEM_QUIRK(2,  1), /* off-chip devices */
> >   ^
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[50].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[50].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[51].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[51].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[52].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[52].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[53].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[53].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[54].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[54].cfgres.endâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[55].cfgres.startâ) [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: left shift count >= width of type [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: initializer element is not a constant expression [enabled by default]
> > drivers/acpi/pci_mcfg.c:102:2: warning: (near initialization for âmcfg_quirks[55].cfgres.endâ) [enabled by default]
>
> I saw this too. It can be fixed by changes below:
>
> diff --git a/drivers/acpi/pci_mcfg.c b/drivers/acpi/pci_mcfg.c
> index 7319188..3d7c5cc 100644
> --- a/drivers/acpi/pci_mcfg.c
> +++ b/drivers/acpi/pci_mcfg.c
> @@ -98,16 +98,16 @@ struct mcfg_fixup {
>         { "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY,                 \
>         &pci_thunder_ecam_ops }
>         /* SoC pass1.x */
> -   THUNDER_PEM_QUIRK(2,  0),       /* off-chip devices */
> -   THUNDER_PEM_QUIRK(2,  1),       /* off-chip devices */
> -   THUNDER_ECAM_QUIRK(2,  0),
> -   THUNDER_ECAM_QUIRK(2,  1),
> -   THUNDER_ECAM_QUIRK(2,  2),
> -   THUNDER_ECAM_QUIRK(2,  3),
> -   THUNDER_ECAM_QUIRK(2, 10),
> -   THUNDER_ECAM_QUIRK(2, 11),
> -   THUNDER_ECAM_QUIRK(2, 12),
> -   THUNDER_ECAM_QUIRK(2, 13),
> + THUNDER_PEM_QUIRK(2, 0UL),  /* off-chip devices */
> + THUNDER_PEM_QUIRK(2, 1UL),  /* off-chip devices */
> + THUNDER_ECAM_QUIRK(2, 0UL),
> + THUNDER_ECAM_QUIRK(2, 1UL),
> + THUNDER_ECAM_QUIRK(2, 2UL),
> + THUNDER_ECAM_QUIRK(2, 3UL),
> + THUNDER_ECAM_QUIRK(2, 10UL),
> + THUNDER_ECAM_QUIRK(2, 11UL),
> + THUNDER_ECAM_QUIRK(2, 12UL),
> + THUNDER_ECAM_QUIRK(2, 13UL),

The UL suffix is needed for *THUNDER_PEM_QUIRK* only. THUNDER_ECAM_QUIRK 
is fine.

-   THUNDER_PEM_QUIRK(2,  0),       /* off-chip devices */
-   THUNDER_PEM_QUIRK(2,  1),       /* off-chip devices */
+   THUNDER_PEM_QUIRK(2, 0UL),  /* off-chip devices */
+   THUNDER_PEM_QUIRK(2, 1UL),  /* off-chip devices */

Tomasz