Re: [PATCH 21/22 v2] staging/lustre/libcfs: Convert to hotplug state machine

[Greg Kroah-Hartman]

On Fri, Dec 02, 2016 at 11:18:25AM +0100, Sebastian Andrzej Siewior wrote:
> From: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> 
> Install the callbacks via the state machine.
> Cc: Oleg Drokin <oleg.drokin@xxxxxxxxx>
> Cc: Andreas Dilger <andreas.dilger@xxxxxxxxx>
> Cc: James Simmons <jsimmons@xxxxxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: lustre-devel@xxxxxxxxxxxxxxxx
> Cc: devel@xxxxxxxxxxxxxxxxxxxx
> Signed-off-by: Anna-Maria Gleixner <anna-maria@xxxxxxxxxxxxx>
> [bigeasy: rebase to linux-next]
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
> ---
> v1âv2: rebase to linux-next
> 
> Side note: Is there a reason the handle the down state very late at
> CPU_DEAD time and use the counterpart of the online callback (the old
> CPU_DOWN_PREPARE state).

You need a blank line before the cc: lines in your changelog please...

thanks,

greg k-h