Re: [PATCH 2/8] x86/head: Refactor 32-bit pgtable setup
From: hpa
Date: Sat Dec 03 2016 - 01:48:23 EST
On December 2, 2016 9:49:50 PM PST, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>* Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> wrote:
>
>> > It is tricky to do so safely, because at this stage almost nothing
>of the C
>> > execution environment has been set up.
>
>Yeah - but we do have a fair amount of early C code though.
>
>> I can still give it a try but I'd rather not tie it to this (Xen PVH)
>patch
>> series. Which would leave me with two options: either keep what this
>patch does,
>> leaving it as assembly (requires your ack), or have Xen code build
>the pages on
>> its own.
>
>If you give it a try in a subsequent patch (please Cc: me) then it's OK
>to me:
>
> Acked-by: Ingo Molnar <mingo@xxxxxxxxxx>
>
>Feel free to carry it in the Xen tree.
>
>Thanks,
>
> Ingo
It's true that it is now possible to run pre-paging C code. It would be so much better if Xen could simply go though the normal code path like any civilized machine.
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.