Re: [PATCH 1/1] edac: fix improper return value

From: Borislav Petkov
Date: Sun Dec 04 2016 - 05:08:22 EST


On Sun, Dec 04, 2016 at 02:07:18PM +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@xxxxxxx>
>
> When the call to zalloc_cpumask_var() fails, returning "false" seems
> improper. The real value of macro "false" is 0, and 0 means no error.
> This patch fixes the bug, returning "-ENOMEM".
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=189071

That bugzilla entry wasn't really needed.

> Signed-off-by: Pan Bian <bianpan2016@xxxxxxx>
> ---
> drivers/edac/amd64_edac.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Applied,
thanks.

--
Regards/Gruss,
Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.