Re: [PATCH] zram: restrict add/remove attributes to root only

[Sergey Senozhatsky]

On (12/04/16 12:28), Greg KH wrote:
> > [..]
> > 
> > > Why can't a normal user read the attribute?  Does a read actually modify
> > > something?
> > 
> > yes, it does.
> 
> Oh that's totally and completely broken then.
> 
> Reading from a sysfs file should NEVER cause side affects to the system.
> Please fix up this api.

we have a mechanism for such API changes -- there is a bunch of deprecated
sysfs attrs that we will remove in 4.11; so I'll mark hot_add/hot_remove
as deprecated and switch to char device (as you suggested). thanks.

	-ss