Re: [PATCH] mlx4: Use kernel sizeof and alloc styles

From: Eric Dumazet
Date: Sun Dec 04 2016 - 16:17:16 EST


On Sun, 2016-12-04 at 12:11 -0800, Joe Perches wrote:
> Convert sizeof foo to sizeof(foo) and allocations with multiplications
> to the appropriate kcalloc/kmalloc_array styles.
>
> Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> ---

Gah.

This is one of the hotest NIC driver on linux at this moment,
with XDP and other efforts going on.

Some kmalloc() are becoming kmalloc_node() in some dev branches, and
there is no kmalloc_array_node() yet.

This kind of patch is making rebases/backports very painful.

Could we wait ~6 months before doing such cleanup/changes please ?

If you believe a bug needs a fix, please send a patch to address it.

Thanks.