Re: [PATCH] crypto: rsa - fix a potential race condition in build

From: Yang Shi
Date: Mon Dec 05 2016 - 12:49:46 EST


On 12/4/2016 10:48 PM, Herbert Xu wrote:
On Fri, Dec 02, 2016 at 03:41:04PM -0800, Yang Shi wrote:
When building kernel with RSA enabled with multithreaded, the below
compile failure might be caught:

| /buildarea/kernel-source/crypto/rsa_helper.c:18:28: fatal error: rsapubkey-asn1.h: No such file or directory
| #include "rsapubkey-asn1.h"
| ^
| compilation terminated.
| CC crypto/rsa-pkcs1pad.o
| CC crypto/algboss.o
| CC crypto/testmgr.o
| make[3]: *** [/buildarea/kernel-source/scripts/Makefile.build:289: crypto/rsa_helper.o] Error 1
| make[3]: *** Waiting for unfinished jobs....
| make[2]: *** [/buildarea/kernel-source/Makefile:969: crypto] Error 2
| make[1]: *** [Makefile:150: sub-make] Error 2
| make: *** [Makefile:24: __sub-make] Error 2

The header file is not generated before rsa_helper is compiled, so
adding dependency to avoid such issue.

Signed-off-by: Yang Shi <yang.shi@xxxxxxxxxxxxx>
This should already be fixed in the latest crypto tree. Could
you please double-check?

Thanks, Herbert, I just found the commit. Please ignore my patch, sorry for the inconvenience.

I will backport that commit to our kernel tree.

Yang


Thanks,