Re: [PATCH V2 net 02/20] net/ena: fix error handling when probe fails

[Netanel Belgazal]

On 12/05/2016 06:09 AM, Matt Wilson wrote:
> On Sun, Dec 04, 2016 at 03:19:20PM +0200, Netanel Belgazal wrote:
> > When driver fails in probe, it will release all resources, including
> > adapter.
> > In case of probe failure, ena_remove should not try to free the adapter
> > resources.
> Please word wrap your commit message around 75 columns.

OK

> > Signed-off-by: Netanel Belgazal <netanel@xxxxxxxxxxxxxxxxx>
> Reviewed-by: Matt Wilson <msw@xxxxxxxxxx>
>
> > ---
> >   drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> > index 33a760e..397c9bc 100644
> > --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> > +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> > @@ -3054,6 +3054,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> >   err_free_region:
> >   	ena_release_bars(ena_dev, pdev);
> >   err_free_ena_dev:
> > +	pci_set_drvdata(pdev, NULL);
> >   	vfree(ena_dev);
> >   err_disable_device:
> >   	pci_disable_device(pdev);